• Sean Christopherson's avatar
    KVM: x86/mmu: Don't step down in the TDP iterator when zapping all SPTEs · 0103098f
    Sean Christopherson authored
    Set the min_level for the TDP iterator at the root level when zapping all
    SPTEs to optimize the iterator's try_step_down().  Zapping a non-leaf
    SPTE will recursively zap all its children, thus there is no need for the
    iterator to attempt to step down.  This avoids rereading the top-level
    SPTEs after they are zapped by causing try_step_down() to short-circuit.
    
    In most cases, optimizing try_step_down() will be in the noise as the cost
    of zapping SPTEs completely dominates the overall time.  The optimization
    is however helpful if the zap occurs with relatively few SPTEs, e.g. if KVM
    is zapping in response to multiple memslot updates when userspace is adding
    and removing read-only memslots for option ROMs.  In that case, the task
    doing the zapping likely isn't a vCPU thread, but it still holds mmu_lock
    for read and thus can be a noisy neighbor of sorts.
    Reviewed-by: default avatarBen Gardon <bgardon@google.com>
    Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
    Message-Id: <20210812181414.3376143-3-seanjc@google.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    0103098f
tdp_mmu.c 44.4 KB