• Longlong Yao's avatar
    drm/amdgpu: fix calltrace warning in amddrm_buddy_fini · 01382501
    Longlong Yao authored
    The following call trace is observed when removing the amdgpu driver, which
    is caused by that BOs allocated for psp are not freed until removing.
    
    [61811.450562] RIP: 0010:amddrm_buddy_fini.cold+0x29/0x47 [amddrm_buddy]
    [61811.450577] Call Trace:
    [61811.450577]  <TASK>
    [61811.450579]  amdgpu_vram_mgr_fini+0x135/0x1c0 [amdgpu]
    [61811.450728]  amdgpu_ttm_fini+0x207/0x290 [amdgpu]
    [61811.450870]  amdgpu_bo_fini+0x27/0xa0 [amdgpu]
    [61811.451012]  gmc_v9_0_sw_fini+0x4a/0x60 [amdgpu]
    [61811.451166]  amdgpu_device_fini_sw+0x117/0x520 [amdgpu]
    [61811.451306]  amdgpu_driver_release_kms+0x16/0x30 [amdgpu]
    [61811.451447]  devm_drm_dev_init_release+0x4d/0x80 [drm]
    [61811.451466]  devm_action_release+0x15/0x20
    [61811.451469]  release_nodes+0x40/0xb0
    [61811.451471]  devres_release_all+0x9b/0xd0
    [61811.451473]  __device_release_driver+0x1bb/0x2a0
    [61811.451476]  driver_detach+0xf3/0x140
    [61811.451479]  bus_remove_driver+0x6c/0xf0
    [61811.451481]  driver_unregister+0x31/0x60
    [61811.451483]  pci_unregister_driver+0x40/0x90
    [61811.451486]  amdgpu_exit+0x15/0x447 [amdgpu]
    
    For smu v13_0_2, if the GPU supports xgmi, refer to
    
    commit f5c7e779 ("drm/amdgpu: Adjust removal control flow for smu v13_0_2"),
    
    it will run gpu recover in AMDGPU_RESET_FOR_DEVICE_REMOVE mode when removing,
    which makes all devices in hive list have hw reset but no resume except the
    basic ip blocks, then other ip blocks will not call .hw_fini according to
    ip_block.status.hw.
    
    Since psp_free_shared_bufs just includes some software operations, so move
    it to psp_sw_fini.
    Reviewed-by: default avatarGuchun Chen <guchun.chen@amd.com>
    Reviewed-by: default avatarFeifei Xu <Feifei.Xu@amd.com>
    Signed-off-by: default avatarLonglong Yao <Longlong.Yao@amd.com>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    01382501
amdgpu_psp.c 100 KB