• Russell King's avatar
    [PATCH] Fix pcnet_cs network hotplug · 019904d0
    Russell King authored
    pcnet_cs registers the network device too early.  The effect of this
    is that the networking hotplug scripts are unable to bring the device
    up automatically.
    
    There are two issues:
    - we were registering the net device before we finished setting up
      the device (eg, reading the MAC address.)
    - we were using DEV_CONFIG_PENDING to block the net device "open"
      callback, and as we know the other methods may be called prior
      to open.
    
    My only concern with this patch is that we set info->node.dev_name
    after we register the net device, so use of cardctl during the
    hotplug scripts may give unexpected results.  However, I am not
    aware of anyone using cardctl to read the device name in network
    hotplug scripts.
    
    Please review and merge.  Thanks.
    019904d0
pcnet_cs.c 48 KB