• Tejun Heo's avatar
    workqueue: fix find_worker_executing_work() brekage from hashtable conversion · 023f27d3
    Tejun Heo authored
    42f8570f ("workqueue: use new hashtable implementation") incorrectly
    made busy workers hashed by the pointer value of worker instead of
    work.  This broke find_worker_executing_work() which in turn broke a
    lot of fundamental operations of workqueue - non-reentrancy and
    flushing among others.  The flush malfunction triggered warning in
    disk event code in Fengguang's automated test.
    
     write_dev_root_ (3265) used greatest stack depth: 2704 bytes left
     ------------[ cut here ]------------
     WARNING: at /c/kernel-tests/src/stable/block/genhd.c:1574 disk_clear_events+0x\
    cf/0x108()
     Hardware name: Bochs
     Modules linked in:
     Pid: 3328, comm: ata_id Not tainted 3.7.0-01930-gbff6343 #1167
     Call Trace:
      [<ffffffff810997c4>] warn_slowpath_common+0x83/0x9c
      [<ffffffff810997f7>] warn_slowpath_null+0x1a/0x1c
      [<ffffffff816aea77>] disk_clear_events+0xcf/0x108
      [<ffffffff811bd8be>] check_disk_change+0x27/0x59
      [<ffffffff822e48e2>] cdrom_open+0x49/0x68b
      [<ffffffff81ab0291>] idecd_open+0x88/0xb7
      [<ffffffff811be58f>] __blkdev_get+0x102/0x3ec
      [<ffffffff811bea08>] blkdev_get+0x18f/0x30f
      [<ffffffff811bebfd>] blkdev_open+0x75/0x80
      [<ffffffff8118f510>] do_dentry_open+0x1ea/0x295
      [<ffffffff8118f5f0>] finish_open+0x35/0x41
      [<ffffffff8119c720>] do_last+0x878/0xa25
      [<ffffffff8119c993>] path_openat+0xc6/0x333
      [<ffffffff8119cf37>] do_filp_open+0x38/0x86
      [<ffffffff81190170>] do_sys_open+0x6c/0xf9
      [<ffffffff8119021e>] sys_open+0x21/0x23
      [<ffffffff82c1c3d9>] system_call_fastpath+0x16/0x1b
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
    Cc: Sasha Levin <sasha.levin@oracle.com>
    023f27d3
workqueue.c 106 KB