• Sergei Trofimovich's avatar
    scsi: hpsa: Fix boot on ia64 (atomic_t alignment) · 02ec1442
    Sergei Trofimovich authored
    Boot failure was observed on an HP rx3600 ia64 machine with RAID bus
    controller: Hewlett-Packard Company Smart Array P600:
    
        kernel unaligned access to 0xe000000105dd8b95, ip=0xa000000100b87551
        kernel unaligned access to 0xe000000105dd8e95, ip=0xa000000100b87551
        hpsa 0000:14:01.0: Controller reports max supported commands of 0 Using 16 instead. Ensure that firmware is up to date.
        swapper/0[1]: error during unaligned kernel access
    
    The unaligned access comes from 'struct CommandList' that happens to be
    packed. Commit f749d8b7 ("scsi: hpsa: Correct dev cmds outstanding for
    retried cmds") introduced unexpected padding and unaligned atomic_t from
    natural alignment to something else.
    
    This change removes packing annotation from a struct not intended to be
    sent to controller as is. This restores natural `atomic_t` alignment.
    
    The change was tested on the same rx3600 machine.
    
    Link: https://lore.kernel.org/r/20210330071958.3788214-2-slyfox@gentoo.org
    Fixes: f749d8b7 ("scsi: hpsa: Correct dev cmds outstanding for retried cmds")
    CC: linux-ia64@vger.kernel.org
    CC: linux-kernel@vger.kernel.org
    CC: storagedev@microchip.com
    CC: linux-scsi@vger.kernel.org
    CC: Joe Szczypek <jszczype@redhat.com>
    CC: Scott Benesh <scott.benesh@microchip.com>
    CC: Scott Teel <scott.teel@microchip.com>
    CC: Tomas Henzl <thenzl@redhat.com>
    CC: "Martin K. Petersen" <martin.petersen@oracle.com>
    CC: Don Brace <don.brace@microchip.com>
    Reported-by: default avatarJohn Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
    Suggested-by: default avatarDon Brace <don.brace@microchip.com>
    Reviewed-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarSergei Trofimovich <slyfox@gentoo.org>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    02ec1442
hpsa_cmd.h 28.5 KB