• Christian König's avatar
    drm/amdgpu: revert "take runtime pm reference when we attach a buffer" v2 · 030631e9
    Christian König authored
    This reverts commit b8c415e3 ("drm/amdgpu: take runtime pm reference
    when we attach a buffer") and commit 425285d3 ("drm/amdgpu: add amdgpu
    runpm usage trace for separate funcs").
    
    Taking a runtime pm reference for DMA-buf is actually completely
    unnecessary and even dangerous.
    
    The problem is that calling pm_runtime_get_sync() from the DMA-buf
    callbacks is illegal because we have the reservation locked here
    which is also taken during resume. So this would deadlock.
    
    When the buffer is in GTT it is still accessible even when the GPU
    is powered down and when it is in VRAM the buffer gets migrated to
    GTT before powering down.
    
    The only use case which would make it mandatory to keep the runtime
    pm reference would be if we pin the buffer into VRAM, and that's not
    something we currently do.
    
    v2: improve the commit message
    Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
    Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    CC: stable@vger.kernel.org
    030631e9
amdgpu_trace.h 17 KB