• Yuval Mintz's avatar
    qede: Fix Tx timeout due to xmit_more · 039a3927
    Yuval Mintz authored
    Driver uses netif_tx_queue_stopped() to make sure the xmit_more
    indication will be honored, but that only checks for DRV_XOFF.
    
    At the same time, it's possible that during transmission the DQL will
    close the transmission queue with STACK_XOFF indication.
    In re-configuration flows, when the threshold is relatively low, it's
    possible that the device has no pending tranmissions, and during
    tranmission the driver would miss doorbelling the HW.
    Since there are no pending transmission, there will never be a Tx
    completion [and thus the DQL would not remove the STACK_XOFF indication],
    eventually causing the Tx queue to timeout.
    
    While we're at it - also doorbell in case driver has to close the
    transmission queue on its own [although this one is less important -
    if the ring is full, we're bound to receive completion eventually,
    which means the doorbell would only be postponed and not indefinetly
    blocked].
    
    Fixes: 312e0676 ("qede: Utilize xmit_more")
    Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@qlogic.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    039a3927
qede_main.c 99.5 KB