• Chris Mason's avatar
    Btrfs: don't delay inode ref updates during log replay · 6f896054
    Chris Mason authored
    Commit 1d52c78a (Btrfs: try not to ENOSPC on log replay) added a
    check to skip delayed inode updates during log replay because it
    confuses the enospc code.  But the delayed processing will end up
    ignoring delayed refs from log replay because the inode itself wasn't
    put through the delayed code.
    
    This can end up triggering a warning at commit time:
    
    WARNING: CPU: 2 PID: 778 at fs/btrfs/delayed-inode.c:1410 btrfs_assert_delayed_root_empty+0x32/0x34()
    
    Which is repeated for each commit because we never process the delayed
    inode ref update.
    
    The fix used here is to change btrfs_delayed_delete_inode_ref to return
    an error if we're currently in log replay.  The caller will do the ref
    deletion immediately and everything will work properly.
    Signed-off-by: default avatarChris Mason <clm@fb.com>
    cc: stable@vger.kernel.org # v3.18 and any stable series that picked 1d52c78a
    6f896054
delayed-inode.c 51.6 KB