• qize wang's avatar
    mwifiex: Fix heap overflow in mmwifiex_process_tdls_action_frame() · 1e58252e
    qize wang authored
    mwifiex_process_tdls_action_frame() without checking
    the incoming tdls infomation element's vality before use it,
    this may cause multi heap buffer overflows.
    
    Fix them by putting vality check before use it.
    
    IE is TLV struct, but ht_cap and  ht_oper aren’t TLV struct.
    the origin marvell driver code is wrong:
    
    memcpy(&sta_ptr->tdls_cap.ht_oper, pos,....
    memcpy((u8 *)&sta_ptr->tdls_cap.ht_capb, pos,...
    
    Fix the bug by changing pos(the address of IE) to
    pos+2 ( the address of IE value ).
    Signed-off-by: default avatarqize wang <wangqize888888888@gmail.com>
    Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
    1e58252e
tdls.c 44.2 KB