• Gustavo A. R. Silva's avatar
    qlcnic: remove unnecessary static in qlcnic_dump_fw() · 048578a1
    Gustavo A. R. Silva authored
    Remove unnecessary static on local variable fw_dump_ops.
    Such variable is initialized before being used, on every
    execution path throughout the function. The static has no
    benefit and, removing it reduces the object file size.
    
    This issue was detected using Coccinelle and the following semantic patch:
    
    @bad exists@
    position p;
    identifier x;
    type T;
    @@
    
    static T x@p;
    ...
    x = <+...x...+>
    
    @@
    identifier x;
    expression e;
    type T;
    position p != bad.p;
    @@
    
    -static
     T x@p;
     ... when != x
         when strict
    ?x = e;
    
    In the following log you can see a difference in the object file size.
    This log is the output of the size command, before and after the code
    change:
    
    before:
       text    data     bss     dec     hex filename
      19032    2136      64   21232    52f0 drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.o
    
    after:
       text    data     bss     dec     hex filename
      19020    2048       0   21068    524c drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.o
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    048578a1
qlcnic_minidump.c 34.4 KB