• Vadim Zaliva's avatar
    Input: appletouch - fix integer overflow issue · 04b4b88c
    Vadim Zaliva authored
    When reading data from Geyser 2 touchpads used on post Oct 2005 Apple
    PowerBooks the driver was casting X and Y coordinates values to
    'signed char'. Testing on one of such PowerBooks I have noticed that
    touchpad always generates positive values, but some of them are greater
    that 127, and thus, when cast to 'signed char' being interpreted as
    a negative.
    
    Such bigger values have been observed infrequently, closer to the
    edges of a touchpad, so the problem was not very visible.
    Nevertheless, the patch would potentially improve touchpad
    driver accuracy.
    Signed-off-by: default avatarVadim Zaliva <lord@crocodile.org>
    Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
    04b4b88c
appletouch.c 24.4 KB