• Peter Zijlstra's avatar
    locking/rwsem: Fix down_write_killable() · 04cafed7
    Peter Zijlstra authored
    The new signal_pending exit path in __rwsem_down_write_failed_common()
    was fingered as breaking his kernel by Tetsuo Handa.
    
    Upon inspection it was found that there are two things wrong with it;
    
     - it forgets to remove WAITING_BIAS if it leaves the list empty, or
     - it forgets to wake further waiters that were blocked on the now
       removed waiter.
    
    Especially the first issue causes new lock attempts to block and stall
    indefinitely, as the code assumes that pending waiters mean there is
    an owner that will wake when it releases the lock.
    Reported-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    Tested-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    Tested-by: default avatarMichal Hocko <mhocko@kernel.org>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Chris Zankel <chris@zankel.net>
    Cc: David S. Miller <davem@davemloft.net>
    Cc: Davidlohr Bueso <dave@stgolabs.net>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Max Filippov <jcmvbkbc@gmail.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Tony Luck <tony.luck@intel.com>
    Cc: Vince Weaver <vincent.weaver@maine.edu>
    Cc: Waiman Long <Waiman.Long@hpe.com>
    Link: http://lkml.kernel.org/r/20160512115745.GP3192@twins.programming.kicks-ass.netSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    04cafed7
rwsem-xadd.c 16.5 KB