• Gustavo A. R. Silva's avatar
    dmaengine: stm32-dma: Use struct_size() helper · 402096cb
    Gustavo A. R. Silva authored
    One of the more common cases of allocation size calculations is finding
    the size of a structure that has a zero-sized array at the end, along
    with memory for some number of elements for that array. For example:
    
    struct stm32_dma_desc {
    	...
            struct stm32_dma_sg_req sg_req[];
    };
    
    Make use of the struct_size() helper instead of an open-coded version
    in order to avoid any potential type mistakes.
    
    So, replace the following function:
    
    static struct stm32_dma_desc *stm32_dma_alloc_desc(u32 num_sgs)
    {
           return kzalloc(sizeof(struct stm32_dma_desc) +
                          sizeof(struct stm32_dma_sg_req) * num_sgs, GFP_NOWAIT);
    }
    
    with:
    
    kzalloc(struct_size(desc, sg_req, num_sgs), GFP_NOWAIT)
    
    This code was detected with the help of Coccinelle.
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Link: https://lore.kernel.org/r/20190830161423.GA3483@embeddedorSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
    402096cb
stm32-dma.c 39.9 KB