• Lars Ellenberg's avatar
    drbd: Fix spurious disk-timeout · 05cbbb39
    Lars Ellenberg authored
    (You should not use disk-timeout anyways,
     see the man page for why...)
    
    We add incoming requests to the tail of some ring list.
    On local completion, requests are removed from that list.
    The timer looks only at the head of that ring list,
    so is supposed to only see the oldest request.
    All protected by a spinlock.
    
    The request object is created with timestamps zeroed out.
    The timestamp was only filled in just before the actual submit.
    But to actually submit the request, we need to give up the spinlock.
    
    If you are unlucky, there is no older still pending request, the timer
    looks at a new request with timestamp still zero (before it even was
    submitted), and 0 + timeout is most likely older than "now".
    
    Better assign the timestamp right when we put the
    request object on said ring list.
    Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
    Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
    Signed-off-by: default avatarJens Axboe <axboe@fb.com>
    05cbbb39
drbd_req.c 50.7 KB