• Mel Gorman's avatar
    sched/numa: Acquire RCU lock for checking idle cores during NUMA balancing · 0621df31
    Mel Gorman authored
    Qian Cai reported the following bug:
    
      The linux-next commit ff7db0bf ("sched/numa: Prefer using an idle CPU as a
      migration target instead of comparing tasks") introduced a boot warning,
    
      [   86.520534][    T1] WARNING: suspicious RCU usage
      [   86.520540][    T1] 5.6.0-rc3-next-20200227 #7 Not tainted
      [   86.520545][    T1] -----------------------------
      [   86.520551][    T1] kernel/sched/fair.c:5914 suspicious rcu_dereference_check() usage!
      [   86.520555][    T1]
      [   86.520555][    T1] other info that might help us debug this:
      [   86.520555][    T1]
      [   86.520561][    T1]
      [   86.520561][    T1] rcu_scheduler_active = 2, debug_locks = 1
      [   86.520567][    T1] 1 lock held by systemd/1:
      [   86.520571][    T1]  #0: ffff8887f4b14848 (&mm->mmap_sem#2){++++}, at: do_page_fault+0x1d2/0x998
      [   86.520594][    T1]
      [   86.520594][    T1] stack backtrace:
      [   86.520602][    T1] CPU: 1 PID: 1 Comm: systemd Not tainted 5.6.0-rc3-next-20200227 #7
    
    task_numa_migrate() checks for idle cores when updating NUMA-related statistics.
    This relies on reading a RCU-protected structure in test_idle_cores() via this
    call chain
    
    task_numa_migrate
      -> update_numa_stats
        -> numa_idle_core
          -> test_idle_cores
    
    While the locking could be fine-grained, it is more appropriate to acquire
    the RCU lock for the entire scan of the domain. This patch removes the
    warning triggered at boot time.
    Reported-by: default avatarQian Cai <cai@lca.pw>
    Reviewed-by: default avatarPaul E. McKenney <paulmck@kernel.org>
    Signed-off-by: default avatarMel Gorman <mgorman@techsingularity.net>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    Fixes: ff7db0bf ("sched/numa: Prefer using an idle CPU as a migration target instead of comparing tasks")
    Link: https://lkml.kernel.org/r/20200227191804.GJ3818@techsingularity.net
    0621df31
fair.c 294 KB