• Rodrigo Vivi's avatar
    drm/xe: Invert mask and val in xe_mmio_wait32. · 063e09af
    Rodrigo Vivi authored
    The order: 'offset, mask, val'; is more common in other
    drivers and in special in i915, where any dev could copy
    a sequence and end up with unexpected behavior.
    
    Done with coccinelle:
    @rule1@
    expression gt, reg, val, mask, timeout, out, atomic;
    @@
    - xe_mmio_wait32(gt, reg, val, mask, timeout, out, atomic)
    + xe_mmio_wait32(gt, reg, mask, val, timeout, out, atomic)
    
    spatch -sp_file mmio.cocci *.c *.h compat-i915-headers/intel_uncore.h \
           --in-place
    
    v2: Rebased after changes on xe_guc_mcr usage of xe_mmio_wait32.
    Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
    Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
    063e09af
xe_guc.c 21.2 KB