• Lyude Paul's avatar
    video/console/vgacon: Print big fat warning with nomodeset · ff459c2d
    Lyude Paul authored
    It's been a pretty good while since kernel modesetting was introduced.
    It has almost entirely replaced previous solutions which required
    userspace modesetting, and I can't even recall any drivers off the top
    of my head for modern day hardware that don't only support one or the
    other. Even nvidia's ugly blob does not require the use of nomodeset,
    and only requires that nouveau be blacklisted.
    
    Effectively, the only thing nomodeset does in the year 2018 is disable
    your graphics drivers. Since VESA is a thing, this will give many users
    the false impression that they've actually fixed an issue they were
    having with their machine simply because the laptop will boot up to a
    degraded GUI. This of course, is never actually the case.
    
    Things get even worse when you consider that there's still an enormous
    amount of tutorials users find on the internet that still suggest adding
    nomodeset, along with various users who have been around long enough to
    still suggest it.
    
    There really isn't any legitimate reason I can see for this to be an
    option that's used by anyone else other then developers, or properly
    informed users. So, let's end the confusion and start printing warnings
    whenever it's enabled.
    Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
    Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    Acked-by: default avatarJani Nikula <jani.nikula@intel.com>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: "Jan H. Schönherr" <jschoenh@amazon.de>
    Cc: Bjorn Helgaas <bhelgaas@google.com>
    Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    ff459c2d
vgacon.c 41.5 KB