• Theodore Ts'o's avatar
    ext4: inline jbd2_journal_[un]register_shrinker() · 0705e8d1
    Theodore Ts'o authored
    The function jbd2_journal_unregister_shrinker() was getting called
    twice when the file system was getting unmounted.  On Power and ARM
    platforms this was causing kernel crash when unmounting the file
    system, when a percpu_counter was destroyed twice.
    
    Fix this by removing jbd2_journal_[un]register_shrinker() functions,
    and inlining the shrinker setup and teardown into
    journal_init_common() and jbd2_journal_destroy().  This means that
    ext4 and ocfs2 now no longer need to know about registering and
    unregistering jbd2's shrinker.
    
    Also, while we're at it, rename the percpu counter from
    j_jh_shrink_count to j_checkpoint_jh_count, since this makes it
    clearer what this counter is intended to track.
    
    Link: https://lore.kernel.org/r/20210705145025.3363130-1-tytso@mit.edu
    Fixes: 4ba3fcdd
    
     ("jbd2,ext4: add a shrinker to release checkpointed buffers")
    Reported-by: default avatarJon Hunter <jonathanh@nvidia.com>
    Reported-by: default avatarSachin Sant <sachinp@linux.vnet.ibm.com>
    Tested-by: Sa...
    0705e8d1
journal.c 88.9 KB