• Kan Liang's avatar
    perf record: Fix "read LOST count failed" msg with sample read · 07d85ba9
    Kan Liang authored
    Hundreds of "read LOST count failed" error messages may be displayed,
    when the below command is launched.
    
    perf record -e '{cpu/mem-loads-aux/,cpu/event=0xcd,umask=0x1/}:S' -a
    
    According to the commit 89e3106f ("libperf: Handle read format
    in perf_evsel__read()"), the PERF_FORMAT_GROUP is only available for
    the leader. However, the record__read_lost_samples() goes through every
    entry of an evlist, which includes both leader and member. The member
    event errors out and triggers the error message. Since there may be
    hundreds of CPUs on a server, the message will be printed hundreds of
    times, which is very annoying.
    
    The message itself is correct, but the pr_err is a overkill. Other error
    messages in the record__read_lost_samples() are all pr_debug. To make
    the output format consistent, change the pr_err("read LOST count
    failed\n"); to pr_debug("read LOST count failed\n");.
    User can still get the message via -v option.
    
    Fixes: e3a23261 ("perf record: Read and inject LOST_SAMPLES events")
    Signed-off-by: default avatarKan Liang <kan.liang@linux.intel.com>
    Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: https://lore.kernel.org/r/20230301150413.27011-1-kan.liang@linux.intel.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    07d85ba9
builtin-record.c 112 KB