• Yoshihiro Shimoda's avatar
    usb: renesas_usbhs: clear the BRDYSTS in usbhsg_ep_enable() · 9ab967e6
    Yoshihiro Shimoda authored
    This patch fixes an issue that unexpected BRDY interruption happens
    when the usb_ep_{enable,disable}() are called with different direction.
    In this case, the driver will cause the following message:
    
     renesas_usbhs e6590000.usb: irq_ready run_error 1 : -16
    
    This issue causes the followings:
     1) A pipe is enabled as transmission
     2) The pipe sent a data
     3) The pipe is disabled and re-enabled as reception.
     4) The pipe got a queue
    
    Since the driver doesn't clear the BRDYSTS flags after 2) above, the issue
    happens. If we add such clearing the flags into the driver, the code will
    become complicate. So, this patch clears the BRDYSTS flag of reception in
    usbhsg_ep_enable() to avoid complicate.
    
    Cc: <stable@vger.kernel.org> # v4.1+ (usbhs_xxxsts_clear() is needed)
    Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
    Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
    9ab967e6
mod_gadget.c 27.8 KB