• Johannes Berg's avatar
    iwlwifi: pcie: fix indexing in command dump for new HW · 08326a97
    Johannes Berg authored
    We got a crash in iwl_trans_pcie_get_cmdlen(), while the TFD was
    being accessed to sum up the lengths.
    
    We want to access the TFD here, which is the information for the
    hardware. We always only allocate 32 buffers for the cmd queue,
    but on newer hardware (using TFH) we can also allocate only a
    shorter hardware array, also only 32 TFDs. Prior to the TFH, we
    had to allocate a bigger TFD array but would make those point to
    a smaller set of buffers.
    
    Additionally, now max_tfd_queue_size is up to 65536, so we can
    access *way* out of bounds of a really only 32-entry array, so
    it crashes.
    
    Fix this by making the TFD index depend on which hardware we are
    using right now.
    
    While changing the calculation, also fix it to not use void ptr
    arithmetic, but cast to u8 * before.
    Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
    Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
    08326a97
trans.c 103 KB