• Suren Baghdasaryan's avatar
    mm: fix use-after-free bug when mm->mmap is reused after being freed · f798a1d4
    Suren Baghdasaryan authored
    oom reaping (__oom_reap_task_mm) relies on a 2 way synchronization with
    exit_mmap.  First it relies on the mmap_lock to exclude from unlock
    path[1], page tables tear down (free_pgtables) and vma destruction.
    This alone is not sufficient because mm->mmap is never reset.
    
    For historical reasons[2] the lock is taken there is also MMF_OOM_SKIP
    set for oom victims before.
    
    The oom reaper only ever looks at oom victims so the whole scheme works
    properly but process_mrelease can opearate on any task (with fatal
    signals pending) which doesn't really imply oom victims.  That means
    that the MMF_OOM_SKIP part of the synchronization doesn't work and it
    can see a task after the whole address space has been demolished and
    traverse an already released mm->mmap list.  This leads to use after
    free as properly caught up by KASAN report.
    
    Fix the issue by reseting mm->mmap so that MMF_OOM_SKIP synchronization
    is not needed anymore.  The MMF_OOM_SKIP is not removed from exit_mmap
    yet but it acts mostly as an optimization now.
    
    [1] 27ae357f ("mm, oom: fix concurrent munlock and oom reaper unmap, v3")
    [2] 21292580 ("mm: oom: let oom_reap_task and exit_mmap run concurrently")
    
    [mhocko@suse.com: changelog rewrite]
    
    Link: https://lore.kernel.org/all/00000000000072ef2c05d7f81950@google.com/
    Link: https://lkml.kernel.org/r/20220215201922.1908156-1-surenb@google.com
    Fixes: 64591e86 ("mm: protect free_pgtables with mmap_lock write lock in exit_mmap")
    Signed-off-by: default avatarSuren Baghdasaryan <surenb@google.com>
    Reported-by: syzbot+2ccf63a4bd07cf39cab0@syzkaller.appspotmail.com
    Suggested-by: default avatarMichal Hocko <mhocko@suse.com>
    Reviewed-by: default avatarRik van Riel <riel@surriel.com>
    Reviewed-by: default avatarYang Shi <shy828301@gmail.com>
    Acked-by: default avatarMichal Hocko <mhocko@suse.com>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Cc: Roman Gushchin <roman.gushchin@linux.dev>
    Cc: Rik van Riel <riel@surriel.com>
    Cc: Minchan Kim <minchan@kernel.org>
    Cc: Kirill A. Shutemov <kirill@shutemov.name>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Cc: Christian Brauner <brauner@kernel.org>
    Cc: Christoph Hellwig <hch@infradead.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: David Hildenbrand <david@redhat.com>
    Cc: Jann Horn <jannh@google.com>
    Cc: Shakeel Butt <shakeelb@google.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Christian Brauner <christian.brauner@ubuntu.com>
    Cc: Florian Weimer <fweimer@redhat.com>
    Cc: Jan Engelhardt <jengelh@inai.de>
    Cc: Tim Murray <timmurray@google.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    f798a1d4
mmap.c 102 KB