• Mark Salyzyn's avatar
    [SCSI] aacraid: prevent copy_from_user() BUG! · 09050715
    Mark Salyzyn authored
    Seen:
    
    	kernel BUG at arch/i386/lib/usercopy.c:872
    
    under a 2.6.18-8.el5 kernel. Traced it to a garbage-in/garbage-out
    ioctl condition in the aacraid driver.
    
    Adaptec's special ioctl scb passthrough needs to check the validity of
    the individual scatter gather count fields to the maximum the adapter
    supports. Doing so will have the side effect of preventing
    copy_from_user() from bugging out while populating the dma buffers.
    This is a hardening effort, issue was triggered by an errant version
    of the management tools and thus the BUG should not be seen in the
    field.
    
    [jejb: fixed up compile failure]
    Signed-off-by: default avatarMark Salyzyn <aacraid@adaptec.com>
    Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
    09050715
commctrl.c 23.2 KB