• Mauro Carvalho Chehab's avatar
    [media] sta2x11_vip: Fix compilation if I2C is not set · 098af4bd
    Mauro Carvalho Chehab authored
    From Fengguang Wu <fengguang.wu@intel.com>:
    
    > drivers/media/pci/sta2x11/sta2x11_vip.c: In function 'sta2x11_vip_init_one':
    > drivers/media/pci/sta2x11/sta2x11_vip.c:1314:2: error: implicit declaration of function 'i2c_get_adapter' [-Werror=implicit-function-declaration]
    > drivers/media/pci/sta2x11/sta2x11_vip.c:1314:15: warning: assignment makes pointer from integer without a cast [enabled by default]
    > drivers/media/pci/sta2x11/sta2x11_vip.c:1330:2: error: implicit declaration of function 'i2c_put_adapter' [-Werror=implicit-function-declaration]
    
    And also:
    
    > warning: (STA2X11_VIP) selects VIDEO_ADV7180 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_V4L2 && I2C)
    > drivers/media/i2c/adv7180.c: In function '__adv7180_status':
    > drivers/media/i2c/adv7180.c:194:2: error: implicit declaration of function 'i2c_smbus_read_byte_data' [-Werror=implicit-function-declaration]
    > drivers/media/i2c/adv7180.c: In function 'adv7180_s_routing':
    > drivers/media/i2c/adv7180.c:251:2: error: implicit declaration of function 'i2c_smbus_write_byte_data' [-Werror=implicit-function-declaration]
    > drivers/media/i2c/adv7180.c: In function 'adv7180_probe':
    > drivers/media/i2c/adv7180.c:551:2: error: implicit declaration of function 'i2c_check_functionality' [-Werror=implicit-function-declaration]
    > drivers/media/i2c/adv7180.c:554:2: error: implicit declaration of function 'i2c_adapter_id' [-Werror=implicit-function-declaration]
    > drivers/media/i2c/adv7180.c: At top level:
    > drivers/media/i2c/adv7180.c:663:1: warning: data definition has no type or storage class [enabled by default]
    > drivers/media/i2c/adv7180.c:663:1: warning: type defaults to 'int' in declaration of 'module_i2c_driver' [-Wimplicit-int]
    > drivers/media/i2c/adv7180.c:663:1: warning: parameter names (without types) in function declaration [enabled by default]
    > drivers/media/i2c/adv7180.c:649:26: warning: 'adv7180_driver' defined but not used [-Wunused-variable]
    
    This is due to the lack of I2C support:
    
    ...
    > CONFIG_I2C is not set
    ...
    
    So, Make sure that sta2x11_vip depends on I2C.
    Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    098af4bd
Kconfig 396 Bytes