• Frediano Ziglio's avatar
    drm/qxl: Move main reference counter to GEM object instead of TTM ones · e07154e2
    Frediano Ziglio authored
    qxl_bo structure has two reference counters, one in the GEM object and
    another in the TTM object. The GEM object keep a counter to the TTM object
    so when GEM counter reached zero the TTM counter (using qxl_bo_unref) was
    decremented. The qxl object is fully freed (both GEM and TTM part are cleaned)
    when the TTM counter reach zero.
    One issue was that surface idr structure has no owning on qxl_bo objects however
    it contains a pointer to qxl_bo object. This caused some nasty race condition
    for instance qxl_bo object was reaped even after counter was already zero.
    This patch fix these races moving main counter (the one used by qxl_bo_(un)ref)
    to GEM object which cleanup routine (qxl_gem_object_free) remove the idr pointer
    (using qxl_surface_evict) when the counters are still valid.
    Signed-off-by: default avatarFrediano Ziglio <fziglio@redhat.com>
    Reviewed-by: default avatarDave Airlie <airlied@redhat.com>
    Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
    e07154e2
qxl_object.c 7.99 KB