• Nicholas Bellinger's avatar
    target: Drop unnecessary CMD_T_DEV_ACTIVE check from transport_lun_remove_cmd · 0b66818a
    Nicholas Bellinger authored
    This patch drops an unnecessary acquire/release of se_cmd->t_state_lock within
    transport_lun_remove_cmd() when checking CMD_T_DEV_ACTIVE for invoking
    target_remove_from_state_list().
    
    For all fast path completion cases, transport_lun_remove_cmd() is always
    called ahead of transport_cmd_check_stop(), and since transport_cmd_check_stop()
    is calling target_remove_from_state_list() when remove_from_lists=true,
    the t_state_lock usage in transport_lun_remove_cmd() can safely be removed.
    
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Roland Dreier <roland@kernel.org>
    Cc: Kent Overstreet <koverstreet@google.com>
    Cc: Or Gerlitz <ogerlitz@mellanox.com>
    Cc: Moussa Ba <moussaba@micron.com>
    Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
    0b66818a
target_core_transport.c 77.6 KB