• Frederic Weisbecker's avatar
    nohz: Revert "nohz: Set isolcpus when nohz_full is set" · 0baabb38
    Frederic Weisbecker authored
    This reverts:
    
      8cb9764f ("nohz: Set isolcpus when nohz_full is set")
    
    We assumed that full-nohz users always want scheduler isolation on full
    dynticks CPUs, therefore we included full-nohz CPUs on cpu_isolated_map.
    
    This means that tasks run by default on CPUs outside the nohz_full range
    unless their affinity is explicity overwritten.
    
    This suits pure isolation workloads but when the machine is needed to
    run common workloads, the available sets of CPUs to run common tasks
    becomes reduced.
    
    We reach an extreme case when CONFIG_NO_HZ_FULL_ALL is enabled as it
    leaves only CPU 0 for non-isolation tasks, which makes people think that
    their supercomputer regressed to 90's UP - which is true in a sense.
    
    Some full-nohz users appear to be interested in running normal workloads
    either before or after an isolation workload. Full-nohz isn't optimized
    toward normal workloads but it's still better than UP performance.
    
    We are reaching a limitation in kernel presets here. Lets revert this
    cpu_isolated_map inclusion and let userspace do its own scheduler
    isolation using cpusets or explicit affinity settings.
    Reported-by: default avatarIngo Molnar <mingo@kernel.org>
    Reported-by: default avatarMike Galbraith <umgwanakikbuti@gmail.com>
    Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Acked-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Cc: Alexey Dobriyan <adobriyan@gmail.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Chris Metcalf <cmetcalf@ezchip.com>
    Cc: Christoph Lameter <cl@linux.com>
    Cc: Dave Jones <davej@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Paul E . McKenney <paulmck@linux.vnet.ibm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Rik van Riel <riel@redhat.com>
    Link: http://lkml.kernel.org/r/1444663283-30068-1-git-send-email-fweisbec@gmail.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    0baabb38
core.c 205 KB