• Eric Dumazet's avatar
    iommu/iova: Avoid false sharing on fq_timer_on · 0d87308c
    Eric Dumazet authored
    In commit 14bd9a60 ("iommu/iova: Separate atomic variables
    to improve performance") Jinyu Qi identified that the atomic_cmpxchg()
    in queue_iova() was causing a performance loss and moved critical fields
    so that the false sharing would not impact them.
    
    However, avoiding the false sharing in the first place seems easy.
    We should attempt the atomic_cmpxchg() no more than 100 times
    per second. Adding an atomic_read() will keep the cache
    line mostly shared.
    
    This false sharing came with commit 9a005a80
    ("iommu/iova: Add flush timer").
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Fixes: 9a005a80 ('iommu/iova: Add flush timer')
    Cc: Jinyu Qi <jinyuqi@huawei.com>
    Cc: Joerg Roedel <jroedel@suse.de>
    Acked-by: default avatarRobin Murphy <robin.murphy@arm.com>
    Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
    0d87308c
iova.c 25.8 KB