• Roel Kluin's avatar
    ARM: OMAP2: possible division by 0 · d94a2edd
    Roel Kluin authored
    In linus' git tree the functions can be found at:
    vi arch/arm/mach-omap2/usb-tusb6010.c +200	- tusb6010_platform_retime()
    vi arch/arm/mach-omap2/gpmc.c +94		- gpmc_get_fclk_period()
    vi arch/arm/mach-omap2/usb-tusb6010.c +53	- tusb_set_async_mode()
    vi arch/arm/mach-omap2/usb-tusb6010.c +111	- tusb_set_sync_mode()
    
    is -ENODEV appropriate when sysclk_ps == 0?
    
    This was found by code analysis, please review.
    ------------------------------>8-------------8<---------------------------------
    gpmc_get_fclk_period() may return 0 when gpmc_l3_clk is not enabled. This is
    not checked in tusb6010_platform_retime() nor in tusb_set_async_mode() it
    seems. In tusb_set_sync_mode() this may result in a division by zero.
    Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
    Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
    d94a2edd
usb-tusb6010.c 8.61 KB