• Alexander Lobakin's avatar
    bitops: unify non-atomic bitops prototypes across architectures · 0e862838
    Alexander Lobakin authored
    Currently, there is a mess with the prototypes of the non-atomic
    bitops across the different architectures:
    
    ret	bool, int, unsigned long
    nr	int, long, unsigned int, unsigned long
    addr	volatile unsigned long *, volatile void *
    
    Thankfully, it doesn't provoke any bugs, but can sometimes make
    the compiler angry when it's not handy at all.
    Adjust all the prototypes to the following standard:
    
    ret	bool				retval can be only 0 or 1
    nr	unsigned long			native; signed makes no sense
    addr	volatile unsigned long *	bitmaps are arrays of ulongs
    
    Next, some architectures don't define 'arch_' versions as they don't
    support instrumentation, others do. To make sure there is always the
    same set of callables present and to ease any potential future
    changes, make them all follow the rule:
     * architecture-specific files define only 'arch_' versions;
     * non-prefixed versions can be defined only in asm-generic files;
    and place the non-prefixed definitions into a new file in
    asm-generic to be included by non-instrumented architectures.
    
    Finally, add some static assertions in order to prevent people from
    making a mess in this room again.
    I also used the %__always_inline attribute consistently, so that
    they always get resolved to the actual operations.
    Suggested-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: default avatarAlexander Lobakin <alexandr.lobakin@intel.com>
    Acked-by: default avatarMark Rutland <mark.rutland@arm.com>
    Reviewed-by: default avatarYury Norov <yury.norov@gmail.com>
    Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: default avatarYury Norov <yury.norov@gmail.com>
    0e862838
non-instrumented-non-atomic.h 533 Bytes