• Arnd Bergmann's avatar
    fs/locks: fix fcntl_getlk64/fcntl_setlk64 stub prototypes · 0ea9fc15
    Arnd Bergmann authored
    My patch to rework oabi fcntl64() introduced a harmless
    sparse warning when file locking is disabled:
    
       arch/arm/kernel/sys_oabi-compat.c:251:51: sparse: sparse: incorrect type in argument 3 (different address spaces) @@     expected struct flock64 [noderef] __user *user @@     got struct flock64 * @@
       arch/arm/kernel/sys_oabi-compat.c:251:51: sparse:     expected struct flock64 [noderef] __user *user
       arch/arm/kernel/sys_oabi-compat.c:251:51: sparse:     got struct flock64 *
       arch/arm/kernel/sys_oabi-compat.c:265:55: sparse: sparse: incorrect type in argument 4 (different address spaces) @@     expected struct flock64 [noderef] __user *user @@     got struct flock64 * @@
       arch/arm/kernel/sys_oabi-compat.c:265:55: sparse:     expected struct flock64 [noderef] __user *user
       arch/arm/kernel/sys_oabi-compat.c:265:55: sparse:     got struct flock64 *
    
    When file locking is enabled, everything works correctly and the
    right data gets passed, but the stub declarations in linux/fs.h
    did not get modified when the calling conventions changed in an
    earlier patch.
    Reported-by: default avatarkernel test robot <lkp@intel.com>
    Fixes: 7e2d8c29 ("ARM: 9111/1: oabi-compat: rework fcntl64() emulation")
    Fixes: a75d30c7 ("fs/locks: pass kernel struct flock to fcntl_getlk/setlk")
    Cc: Christoph Hellwig <hch@lst.de>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Acked-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
    Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
    0ea9fc15
fs.h 120 KB