• Jesper Juhl's avatar
    NFS4: Avoid potential NULL pointer dereference in decode_and_add_ds(). · ad3d2eed
    Jesper Juhl authored
    On Mon, 17 Jan 2011, Mi Jinlong wrote:
    
    >
    >
    > Jesper Juhl:
    > > strrchr() can return NULL if nothing is found. If this happens we'll
    > > dereference a NULL pointer in
    > > fs/nfs/nfs4filelayoutdev.c::decode_and_add_ds().
    > >
    > > I tried to find some other code that guarantees that this can never
    > > happen but I was unsuccessful. So, unless someone else can point to some
    > > code that ensures this can never be a problem, I believe this patch is
    > > needed.
    > >
    > > While I was changing this code I also noticed that all the dprintk()
    > > statements, except one, start with "%s:". The one missing the ":" I added
    > > it to.
    >
    >   Maybe another one also should be changed at decode_and_add_ds() at line 243:
    >
    >    243  printk("%s Decoded address and port %s\n", __func__, buf);
    >
    Missed that one. Thanks.
    Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
    Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
    ad3d2eed
nfs4filelayoutdev.c 11.4 KB