• Tom Zanussi's avatar
    tracing: Handle synthetic event array field type checking correctly · 10819e25
    Tom Zanussi authored
    Since synthetic event array types are derived from the field name,
    there may be a semicolon at the end of the type which should be
    stripped off.
    
    If there are more characters following that, normal type string
    checking will result in an invalid type.
    
    Without this patch, you can end up with an invalid field type string
    that gets displayed in both the synthetic event description and the
    event format:
    
    Before:
    
      # echo 'myevent char str[16]; int v' >> synthetic_events
      # cat synthetic_events
        myevent	char[16]; str; int v
    
      name: myevent
      ID: 1936
      format:
      	field:unsigned short common_type;	offset:0;	size:2;	signed:0;
      	field:unsigned char common_flags;	offset:2;	size:1;	signed:0;
      	field:unsigned char common_preempt_count;	offset:3;	size:1;	signed:0;
      	field:int common_pid;	offset:4;	size:4;	signed:1;
    
      	field:char str[16];;	offset:8;	size:16;	signed:1;
      	field:int v;	offset:40;	size:4;	signed:1;
    
      print fmt: "str=%s, v=%d", REC->str, REC->v
    
    After:
    
      # echo 'myevent char str[16]; int v' >> synthetic_events
      # cat synthetic_events
        myevent	char[16] str; int v
    
      # cat events/synthetic/myevent/format
      name: myevent
      ID: 1936
      format:
    	field:unsigned short common_type;	offset:0;	size:2;	signed:0;
    	field:unsigned char common_flags;	offset:2;	size:1;	signed:0;
    	field:unsigned char common_preempt_count;	offset:3;	size:1;	signed:0;
    	field:int common_pid;	offset:4;	size:4;	signed:1;
    
    	field:char str[16];	offset:8;	size:16;	signed:1;
    	field:int v;	offset:40;	size:4;	signed:1;
    
      print fmt: "str=%s, v=%d", REC->str, REC->v
    
    Link: https://lkml.kernel.org/r/6587663b56c2d45ab9d8c8472a2110713cdec97d.1602598160.git.zanussi@kernel.org
    
    [ <rostedt@goodmis.org>: wrote parse_synth_field() snippet. ]
    Fixes: 4b147936 (tracing: Add support for 'synthetic' events)
    Reported-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
    Tested-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
    Signed-off-by: default avatarTom Zanussi <zanussi@kernel.org>
    Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
    10819e25
trace_events_synth.c 50 KB