• Sachin Prabhu's avatar
    cifs: Do not send echoes before Negotiate is complete · 11087fac
    Sachin Prabhu authored
    commit 62a6cfdd upstream.
    
    commit 4fcd1813 ("Fix reconnect to not defer smb3 session reconnect
    long after socket reconnect") added support for Negotiate requests to
    be initiated by echo calls.
    
    To avoid delays in calling echo after a reconnect, I added the patch
    introduced by the commit b8c60012 ("Call echo service immediately
    after socket reconnect").
    
    This has however caused a regression with cifs shares which do not have
    support for echo calls to trigger Negotiate requests. On connections
    which need to call Negotiation, the echo calls trigger an error which
    triggers a reconnect which in turn triggers another echo call. This
    results in a loop which is only broken when an operation is performed on
    the cifs share. For an idle share, it can DOS a server.
    
    The patch uses the smb_operation can_echo() for cifs so that it is
    called only if connection has been already been setup.
    
    kernel bz: 194531
    Signed-off-by: default avatarSachin Prabhu <sprabhu@redhat.com>
    Tested-by: default avatarJonathan Liu <net147@gmail.com>
    Acked-by: default avatarPavel Shilovsky <pshilov@microsoft.com>
    Signed-off-by: default avatarSteve French <smfrench@gmail.com>
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    11087fac
smb1ops.c 32.2 KB