• Ard Biesheuvel's avatar
    efivarfs: revert "fix memory leak in efivarfs_create()" · ff04f3b6
    Ard Biesheuvel authored
    The memory leak addressed by commit fe5186cf is a false positive:
    all allocations are recorded in a linked list, and freed when the
    filesystem is unmounted. This leads to double frees, and as reported
    by David, leads to crashes if SLUB is configured to self destruct when
    double frees occur.
    
    So drop the redundant kfree() again, and instead, mark the offending
    pointer variable so the allocation is ignored by kmemleak.
    
    Cc: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
    Fixes: fe5186cf ("efivarfs: fix memory leak in efivarfs_create()")
    Reported-by: default avatarDavid Laight <David.Laight@aculab.com>
    Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
    ff04f3b6
inode.c 3.08 KB