• Bob Picco's avatar
    fix sysrq-m oops · 12710a56
    Bob Picco authored
    We aren't sampling for holes in memory.  Thus we encounter a section hole
    with empty section map pointer for SPARSEMEM and OOPs for show_mem.  This
    issue has been seen in 2.6.21, current git and current mm.  The patch below
    is for mainline and mm.  It was boot tested for SPARSEMEM, current VMEMMAP
    of Andy's in mm ml and DISCONTIGMEM.  A slightly different patch will be
    posted to stable for 2.6.21.
    
    Previous to commit f0a5a58a memory_present
    was called for node_start_pfn to node_end_pfn.  This would cover the
    hole(s) with reserved pages and valid sections.  Most SPARSEMEM supported
    arches do a pfn_valid check in show_mem before computing the page structure
    address.
    
    This issue was brought to my attention on IRC by Arnaldo Carvalho de Melo.
    Thanks to Arnaldo for testing.
    Signed-off-by: default avatarBob Picco <bob.picco@hp.com>
    Cc: Chuck Ebbert <cebbert@redhat.com>
    Cc: Andi Kleen <ak@suse.de>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Acked-by: default avatarAndy Whitcroft <apw@shadowen.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    12710a56
init.c 18.7 KB