• Frederic Weisbecker's avatar
    posix-cpu-timers: Fix rearm racing against process tick · 1a3402d9
    Frederic Weisbecker authored
    Since the process wide cputime counter is started locklessly from
    posix_cpu_timer_rearm(), it can be concurrently stopped by operations
    on other timers from the same thread group, such as in the following
    unlucky scenario:
    
             CPU 0                                CPU 1
             -----                                -----
                                               timer_settime(TIMER B)
       posix_cpu_timer_rearm(TIMER A)
           cpu_clock_sample_group()
               (pct->timers_active already true)
    
                                               handle_posix_cpu_timers()
                                                   check_process_timers()
                                                       stop_process_timers()
                                                           pct->timers_active = false
           arm_timer(TIMER A)
    
       tick -> run_posix_cpu_timers()
           // sees !pct->timers_active, ignore
           // our TIMER A
    
    Fix this with simply locking process wide cputime counting start and
    timer arm in the same block.
    Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Signed-off-by: default avatarFrederic Weisbecker <frederic@kernel.org>
    Fixes: 60f2ceaa ("posix-cpu-timers: Remove unnecessary locking around cpu_clock_sample_group")
    Cc: stable@vger.kernel.org
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Eric W. Biederman <ebiederm@xmission.com>
    1a3402d9
posix-cpu-timers.c 42.4 KB