• Mikko Perttunen's avatar
    gpu: host1x: Assign intr waiter inside lock · 5a8d95d2
    Mikko Perttunen authored
    Move the assignment of the ref out-pointer in host1x_intr_add_action
    to happen within the spinlock. With the current arrangement,
    it is possible for the waiter to complete before the assignment
    has happened, which breaks horribly if the waiter completion
    callback tries to use the reference.
    
    In practice, there is currently no situation where this issue can
    manifest -- it was first noticed with the upcoming DMA fence
    implementation patches. As such this doesn't need to be backported.
    Signed-off-by: default avatarMikko Perttunen <mperttunen@nvidia.com>
    Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
    5a8d95d2
intr.c 8.21 KB