• Namhyung Kim's avatar
    perf test: Fix cpu and thread map leaks in basic mmap test · b0faef92
    Namhyung Kim authored
    The evlist has the maps with its own refcounts so we don't need to set
    the pointers to NULL.  Otherwise following error was reported by Asan.
    
      # perf test -v 4
       4: Read samples using the mmap interface      :
      --- start ---
      test child forked, pid 139782
      mmap size 528384B
    
      =================================================================
      ==139782==ERROR: LeakSanitizer: detected memory leaks
    
      Direct leak of 40 byte(s) in 1 object(s) allocated from:
        #0 0x7f1f76daee8f in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
        #1 0x564ba21a0fea in cpu_map__trim_new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:79
        #2 0x564ba21a1a0f in perf_cpu_map__read /home/namhyung/project/linux/tools/lib/perf/cpumap.c:149
        #3 0x564ba21a21cf in cpu_map__read_all_cpu_map /home/namhyung/project/linux/tools/lib/perf/cpumap.c:166
        #4 0x564ba21a21cf in perf_cpu_map__new /home/namhyung/project/linux/tools/lib/perf/cpumap.c:181
        #5 0x564ba1e48298 in test__basic_mmap tests/mmap-basic.c:55
        #6 0x564ba1e278fb in run_test tests/builtin-test.c:428
        #7 0x564ba1e278fb in test_and_print tests/builtin-test.c:458
        #8 0x564ba1e29a53 in __cmd_test tests/builtin-test.c:679
        #9 0x564ba1e29a53 in cmd_test tests/builtin-test.c:825
        #10 0x564ba1e95cb4 in run_builtin /home/namhyung/project/linux/tools/perf/perf.c:313
        #11 0x564ba1d1fa88 in handle_internal_command /home/namhyung/project/linux/tools/perf/perf.c:365
        #12 0x564ba1d1fa88 in run_argv /home/namhyung/project/linux/tools/perf/perf.c:409
        #13 0x564ba1d1fa88 in main /home/namhyung/project/linux/tools/perf/perf.c:539
        #14 0x7f1f768e4d09 in __libc_start_main ../csu/libc-start.c:308
    
        ...
      test child finished with 1
      ---- end ----
      Read samples using the mmap interface: FAILED!
      failed to open shell test directory: /home/namhyung/libexec/perf-core/tests/shell
    Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
    Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Leo Yan <leo.yan@linaro.org>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Link: https://lore.kernel.org/r/20210301140409.184570-2-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    b0faef92
mmap-basic.c 4.28 KB