• Rodrigo Vivi's avatar
    drm/i915: Fix random aux transactions failures. · 14e01889
    Rodrigo Vivi authored
    Mainly aux communications on sink_crc
    were failing a lot randomly on recent platforms.
    The first solution was to try to use intel_dp_dpcd_read_wake, but then
    it was suggested to move retries to drm level.
    
    Since drm level was already taking care of retries and didn't want
    to through random retries on that level the second solution was to
    put the retries at aux_transfer layer what was nacked.
    
    So I realized we had so many retries in different places and
    started to organize that a bit. During this organization I noticed
    that we weren't handing at all the case were the message size was
    zeroed. And this was exactly the case that was affecting sink_crc.
    
    Also we weren't respect BSPec who says this size message = 0 or > 20
    are forbidden.
    
    It is a fact that we still have no clue why we are getting this
    forbidden value there. But anyway we need to handle that for now
    so we return -EBUSY and drm level takes care of the retries that
    are already in place.
    
    v2: Print debug messsage when this case is reached as suggested
        by Jani.
    v3: This patch is crucial to make PSR test cases reliably working
        on SKL. So split this patch from the aux re-org series and add
        a FIXME as a promisse to continue that effort besides reminding
        to remove the sleep when that is merged.
    v4: Use a bigger usleep range so kernel doesn't need to be interrupted
        on a exact time, as suggested by Paulo.
        But anyway we should discuss the better time
        ranges on the EBUSY handle re-org at drm level since this one here
        is temporary.
    v5: s/1000,1500/1000, 1500/ (by Paulo).
    
    Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
    Cc: Jani Nikula <jani.nikula@intel.com>
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
    Tested-by: Daniel Stone <daniels@collabora.com> # SKL
    Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
    Reviewed-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/1449774747-2772-1-git-send-email-rodrigo.vivi@intel.com
    14e01889
intel_dp.c 170 KB