• Paul Jakma's avatar
    NIU: fix incorrect error return, missed in previous revert · 15bbf8bb
    Paul Jakma authored
    Commit 7930742d, reverting 26fd962b, missed out on reverting an incorrect
    change to a return value.  The niu_pci_vpd_scan_props(..) == 1 case appears
    to be a normal path - treating it as an error and return -EINVAL was
    breaking VPD_SCAN and causing the driver to fail to load.
    
    Fix, so my Neptune card works again.
    
    Cc: Kangjie Lu <kjlu@umn.edu>
    Cc: Shannon Nelson <shannon.lee.nelson@gmail.com>
    Cc: David S. Miller <davem@davemloft.net>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: stable <stable@vger.kernel.org>
    Fixes: 7930742d
    
     ('Revert "niu: fix missing checks of niu_pci_eeprom_read"')
    Signed-off-by: default avatarPaul Jakma <paul@jakma.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    15bbf8bb
niu.c 229 KB