• Jesper Juhl's avatar
    NFS: Remove dead code from nfs_fs_mount() · 160bc160
    Jesper Juhl authored
    In fs/nfs/super.c::nfs_fs_mount() we test for a NULL 'data':
    
    ...
     		if (data == NULL || mntfh == NULL)
     			goto out_free_fh;
    ...
    
    and then further down in the function we test 'data' again:
    
    ...
     			nfs_fscache_get_super_cookie(
     				s, data ? data->fscache_uniq : NULL, NULL);
    ...
    
    this second check is just dead code since there is no way 'data' could
    possibly be NULL here.
    We also rely on a non-NULL 'data' in more than one location between these
    two tests, further proving the point that the second test is bogus.
    
    This patch removes the dead code.
    Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
    Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
    160bc160
super.c 76.3 KB