• He Zhe's avatar
    mips/oprofile: Fix fallthrough placement · 91dbd73a
    He Zhe authored
    We want neither
    "
    include/linux/compiler_attributes.h:201:41: warning: statement will never
    be executed [-Wswitch-unreachable]
      201 | # define fallthrough __attribute__((__fallthrough__))
          |                      ^~~~~~~~~~~~~
    "
    nor
    "
    include/linux/compiler_attributes.h:201:41: warning: attribute
    'fallthrough' not preceding a case label or default label
      201 | # define fallthrough __attribute__((__fallthrough__))
          |                      ^~~~~~~~~~~~~
    "
    
    It's not worth adding one more macro. Let's simply place the fallthrough
    in between the expansions.
    
    Fixes: c9b02990 ("MIPS: Use fallthrough for arch/mips")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarHe Zhe <zhe.he@windriver.com>
    Reviewed-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
    Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
    91dbd73a
op_model_mipsxx.c 10.2 KB