• Nadav Amit's avatar
    KVM: vmx: Unavailable DR4/5 is checked before CPL · 16f8a6f9
    Nadav Amit authored
    If DR4/5 is accessed when it is unavailable (since CR4.DE is set), then #UD
    should be generated even if CPL>0. This is according to Intel SDM Table 6-2:
    "Priority Among Simultaneous Exceptions and Interrupts".
    
    Note, that this may happen on the first DR access, even if the host does not
    sets debug breakpoints. Obviously, it occurs when the host debugs the guest.
    
    This patch moves the DR4/5 checks from __kvm_set_dr/_kvm_get_dr to handle_dr.
    The emulator already checks DR4/5 availability in check_dr_read. Nested
    virutalization related calls to kvm_set_dr/kvm_get_dr would not like to inject
    exceptions to the guest.
    
    As for SVM, the patch follows the previous logic as much as possible. Anyhow,
    it appears the DR interception code might be buggy - even if the DR access
    may cause an exception, the instruction is skipped.
    Signed-off-by: default avatarNadav Amit <namit@cs.technion.ac.il>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    16f8a6f9
kvm_host.h 30.9 KB