• Mark Rutland's avatar
    stackleak: clarify variable names · 1723d39d
    Mark Rutland authored
    
    
    The logic within __stackleak_erase() can be a little hard to follow, as
    `boundary` switches from being the low bound to the high bound mid way
    through the function, and `kstack_ptr` is used to represent the start of
    the region to erase while `boundary` represents the end of the region to
    erase.
    
    Make this a little clearer by consistently using clearer variable names.
    The `boundary` variable is removed, the bounds of the region to erase
    are described by `erase_low` and `erase_high`, and bounds of the task
    stack are described by `task_stack_low` and `task_stack_high`.
    
    As the same time, remove the comment above the variables, since it is
    unclear whether it's intended as rationale, a complaint, or a TODO, and
    is more confusing than helpful.
    
    There should be no functional change as a result of this patch.
    Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
    Cc: Alexander Popov <alex.popov@linux.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Kees Cook <keescook@chromium.org>
    Signed-off-by: default avatarKees Cook <keescook@chromium.org>
    Link: https://lore.kernel.org/r/20220427173128.2603085-6-mark.rutland@arm.com
    1723d39d
stackleak.c 3.72 KB