• WANG Xuerui's avatar
    LoongArch: KVM: Fix input validation of _kvm_get_cpucfg() & kvm_check_cpucfg() · 179af575
    WANG Xuerui authored
    The range check for the CPUCFG ID is wrong (should have been a ||
    instead of &&) and useless in effect, so fix the obvious mistake.
    
    Furthermore, the juggling of the temp return value is unnecessary,
    because it is semantically equivalent and more readable to just
    return at every switch case's end. This is done too to avoid potential
    bugs in the future related to the unwanted complexity.
    
    Also, the return value of _kvm_get_cpucfg is meant to be checked, but
    this was not done, so bad CPUCFG IDs wrongly fall back to the default
    case and 0 is incorrectly returned; check the return value to fix the
    UAPI behavior.
    
    While at it, also remove the redundant range check in kvm_check_cpucfg,
    because out-of-range CPUCFG IDs are already rejected by the -EINVAL
    as returned by _kvm_get_cpucfg().
    
    Fixes: db1ecca2 ("LoongArch: KVM: Add LSX (128bit SIMD) support")
    Fixes: 118e10cd ("LoongArch: KVM: Add LASX (256bit SIMD) support")
    Reviewed-by: default avatarBibo Mao <maobibo@loongson.cn>
    Signed-off-by: default avatarWANG Xuerui <git@xen0n.name>
    Signed-off-by: default avatarHuacai Chen <chenhuacai@loongson.cn>
    179af575
vcpu.c 28.7 KB