• Zachary Amsden's avatar
    [PATCH] i386: Clean up arch/i386/kernel/cpu/mcheck/p4.c · 18420001
    Zachary Amsden authored
    No, just no.  You do not use goto to skip a code block.  You do not
    return an obvious variable from a singly-inlined function and give
    the function a return value.  You don't put unexplained comments
    about kmalloc in code which doesn't do dynamic allocation.  And
    you don't leave stray warnings around for no good reason.
    
    Also, when possible, it is better to use block scoped variables
    because gcc can sometime generate better code.
    Signed-off-by: default avatarZachary Amsden <zach@vmware.com>
    Signed-off-by: default avatarAndi Kleen <ak@suse.de>
    18420001
p4.c 6.41 KB