• Sean Christopherson's avatar
    x86/fault: Decode and print #PF oops in human readable form · 18ea35c5
    Sean Christopherson authored
    Linus pointed out that deciphering the raw #PF error code and printing
    a more human readable message are two different things, and also that
    printing the negative cases is mostly just noise[1].  For example, the
    USER bit doesn't mean the fault originated in user code and stating
    that an oops wasn't due to a protection keys violation isn't interesting
    since an oops on a keys violation is a one-in-a-million scenario.
    
    Remove the per-bit decoding of the error code and instead print:
      - the raw error code
      - why the fault occurred
      - the effective privilege level of the access
      - the type of access
      - whether the fault originated in user code or kernel code
    
    This provides the user with the information needed to triage 99.9% of
    oopses without polluting the log with useless information or conflating
    the error_code with the CPL.
    
    Sample output:
    
        BUG: kernel NULL pointer dereference, address = 0000000000000008
        #PF: supervisor-privileged instruction fetch from kernel code
        #PF: error_code(0x0010) - not-present page
    
        BUG: unable to handle page fault for address = ffffbeef00000000
        #PF: supervisor-privileged instruction fetch from kernel code
        #PF: error_code(0x0010) - not-present page
    
        BUG: unable to handle page fault for address = ffffc90000230000
        #PF: supervisor-privileged write access from kernel code
        #PF: error_code(0x000b) - reserved bit violation
    
    [1] https://lkml.kernel.org/r/CAHk-=whk_fsnxVMvF1T2fFCaP2WrvSybABrLQCWLJyCvHw6NKA@mail.gmail.comSuggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: default avatarSean Christopherson <sean.j.christopherson@intel.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Dave Hansen <dave.hansen@linux.intel.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Rik van Riel <riel@surriel.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Yu-cheng Yu <yu-cheng.yu@intel.com>
    Link: http://lkml.kernel.org/r/20181221213657.27628-3-sean.j.christopherson@intel.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    18ea35c5
fault.c 40.2 KB