• Tejun Heo's avatar
    job control: reorganize wait_task_stopped() · 19e27463
    Tejun Heo authored
    wait_task_stopped() tested task_stopped_code() without acquiring
    siglock and, if stop condition existed, called wait_task_stopped() and
    directly returned the result.  This patch moves the initial
    task_stopped_code() testing into wait_task_stopped() and make
    wait_consider_task() fall through to wait_task_continue() on 0 return.
    
    This is for the following two reasons.
    
    * Because the initial task_stopped_code() test is done without
      acquiring siglock, it may race against SIGCONT generation.  The
      stopped condition might have been replaced by continued state by the
      time wait_task_stopped() acquired siglock.  This may lead to
      unexpected failure of WNOHANG waits.
    
      This reorganization addresses this single race case but there are
      other cases - TASK_RUNNING -> TASK_STOPPED transition and EXIT_*
      transitions.
    
    * Scheduled ptrace updates require changes to the initial test which
      would fit better inside wait_task_stopped().
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Reviewed-by: default avatarOleg Nesterov <oleg@redhat.com>
    Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
    19e27463
exit.c 46.8 KB