• Sebastian Andrzej Siewior's avatar
    net: Use backlog-NAPI to clean up the defer_list. · 80d2eefc
    Sebastian Andrzej Siewior authored
    The defer_list is a per-CPU list which is used to free skbs outside of
    the socket lock and on the CPU on which they have been allocated.
    The list is processed during NAPI callbacks so ideally the list is
    cleaned up.
    Should the amount of skbs on the list exceed a certain water mark then
    the softirq is triggered remotely on the target CPU by invoking a remote
    function call. The raise of the softirqs via a remote function call
    leads to waking the ksoftirqd on PREEMPT_RT which is undesired.
    The backlog-NAPI threads already provide the infrastructure which can be
    utilized to perform the cleanup of the defer_list.
    
    The NAPI state is updated with the input_pkt_queue.lock acquired. It
    order not to break the state, it is needed to also wake the backlog-NAPI
    thread with the lock held. This requires to acquire the use the lock in
    rps_lock_irq*() if the backlog-NAPI threads are used even with RPS
    disabled.
    
    Move the logic of remotely starting softirqs to clean up the defer_list
    into kick_defer_list_purge(). Make sure a lock is held in
    rps_lock_irq*() if backlog-NAPI threads are used. Schedule backlog-NAPI
    for defer_list cleanup if backlog-NAPI is available.
    Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
    Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
    Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
    80d2eefc
skbuff.c 179 KB